Skip to content

Allow to enable the native profile via Maven property #42056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allow to enable the native profile via Maven property #42056

wants to merge 1 commit into from

Conversation

obfischer
Copy link
Contributor

In some cases it could be desired to enable the native profile directly from Maven, so that the caller of Maven does not need to call Maven with -Pnative. To enable this behavior, I added an activation section to the generated POM with the profile definition.

@obfischer
Allow to enable the native profile via Maven property
b0aba82 
In some cases it could be desired to enable the `native` profile
directly from Maven, so that the caller of Maven does not need
to call Maven with `-Pnative`. To enable this behavior, I
added an activation section to the generated POM with
the profile definition.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 29, 2024
@obfischer
Copy link
Contributor Author

Please let me know, if this feature has a chance to get accepted. If yes, I will also include the changes required for native tests.

@philwebb
Copy link
Member

Seems sensible to me. Our resident Maven expert is away at the moment. I'll flag this one for team attention to see if anyone can foresee any problems.

@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label Aug 29, 2024
@snicoll
Copy link
Member

snicoll commented Sep 5, 2024

so that the caller of Maven does not need to call Maven with -Pnative

Can you expand a bit more on that? We don't really want to expand what our parent does without a good reason of doing so. Also I am not sure it would work in child projects as setting the property would be too late for the profile to evaluate. Have you tested that?

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Sep 5, 2024
@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label Sep 5, 2024
@Blackboy007are

This comment was marked as off-topic.

Sign in to view
@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Sep 8, 2024
@philwebb philwebb added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Sep 9, 2024
@Blackboy007are

This comment was marked as spam.

Sign in to view
@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Sep 14, 2024
@Blackboy007are

This comment was marked as spam.

Sign in to view
@philwebb

This comment was marked as outdated.

Sign in to view
@snicoll
Copy link
Member

snicoll commented Sep 16, 2024

I am going to close this as what's been suggested does not work for me. If the feedback is provided and it turns out I was wrong we can reopen this one.

@snicoll snicoll closed this Sep 16, 2024
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Sep 16, 2024
@obfischer
Copy link
Contributor Author

Hi, sorry, currently I am quite busy. I will come back with a more details description.

@Blackboy007are

This comment was marked as abuse.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@obfischer @philwebb @snicoll @Blackboy007are @spring-projects-issues